Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add link to published clone and edit tutorial #24712

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Docs: Add link to published clone and edit tutorial #24712

merged 1 commit into from
Dec 19, 2024

Conversation

aimeeu
Copy link
Contributor

@aimeeu aimeeu commented Dec 18, 2024

Description

The clone and edit tutorial has been published, so I am adding a link to that tutorial in the Job concept page's clone/edit section. This is a 1.9.4 feature.
I also cleaned up a few typos.

Links

Jira: CE-801
Deploy preview: https://nomad-git-ce801-hashicorp.vercel.app/nomad/docs/concepts/job#clone-and-edit

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@aimeeu aimeeu requested review from a team as code owners December 18, 2024 21:41
@aimeeu aimeeu requested a review from EnMod December 18, 2024 21:41
@aimeeu aimeeu added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line and removed backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent labels Dec 18, 2024
@aimeeu aimeeu removed the request for review from EnMod December 18, 2024 21:46
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aimeeu!

@aimeeu aimeeu merged commit 8dc4a94 into main Dec 19, 2024
25 checks passed
@aimeeu aimeeu deleted the ce801 branch December 19, 2024 18:52
aimeeu added a commit that referenced this pull request Dec 19, 2024
aimeeu added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants