keyring: warn if removing a key that was used for encrypting variables #24766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Thanks for doing this @pkazmierczak!
I tested this locally and couldn't get a delete to work even when using the force flag. I believe we need to populate the RPC request force parameter from the HTTP request here in order for the HTTP->RPC translation to handle this new parameter.
It would also be good if we could address the following items:
- The CLI help output doesn't include the new flag option.
- It would be nice to have API and CLI tests to cover this addition as the RPC test did not catch the issue detailed above.
- Document the API and CLI changes.
aimeeu
approved these changes
Jan 3, 2025
|
@jrasell I addressed all your comments, thanks for the thorough review. |
jrasell
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM, thanks @pkazmierczak!
I tested this locally on macOS attempting to delete root keys used for both variable encryption and task workload identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check in the
Keyring.DeleteRPC to make sure we're not trying to delete a key that's been used to encrypt a variable. It also adds a-forceflag for the CLI/API to sidestep that check.Resolves #24591
Internal ref: https://hashicorp.atlassian.net/browse/NET-11829