Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: jobspec updates for dynamic host volumes #24828

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

tgross
Copy link
Member

@tgross tgross commented Jan 9, 2025

The job specification's volume block can claim either static or dynamic host volumes. Update the documentation to explain this and cover the additional fields this exposes.

Ref: #24797
Ref: https://hashicorp.atlassian.net/browse/NET-11482

The job specification's `volume` block can claim either static or dynamic host
volumes. Update the documentation to explain this and cover the additional
fields this exposes.

Ref: #24797
Ref: https://hashicorp.atlassian.net/browse/NET-11482
@aimeeu
Copy link
Contributor

aimeeu commented Jan 9, 2025

Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim! Some formatting suggestions and style nits

website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
website/content/docs/job-specification/volume.mdx Outdated Show resolved Hide resolved
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@tgross tgross merged commit cc8a5ed into dynamic-host-volumes-docs Jan 13, 2025
6 checks passed
@tgross tgross deleted the dhv-docs-jobspec branch January 13, 2025 13:20
tgross added a commit that referenced this pull request Jan 17, 2025
The job specification's `volume` block can claim either static or dynamic host
volumes. Update the documentation to explain this and cover the additional
fields this exposes.

Ref: #24797
Ref: https://hashicorp.atlassian.net/browse/NET-11482

Co-authored-by: Aimee Ukasick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/docs Documentation issues and enhancements theme/jobspec theme/storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants