-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: jobspec updates for dynamic host volumes #24828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job specification's `volume` block can claim either static or dynamic host volumes. Update the documentation to explain this and cover the additional fields this exposes. Ref: #24797 Ref: https://hashicorp.atlassian.net/browse/NET-11482
tgross
added
theme/docs
Documentation issues and enhancements
theme/storage
theme/jobspec
labels
Jan 9, 2025
11 tasks
aimeeu
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim! Some formatting suggestions and style nits
Co-authored-by: Aimee Ukasick <[email protected]>
gulducat
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
tgross
added a commit
that referenced
this pull request
Jan 17, 2025
The job specification's `volume` block can claim either static or dynamic host volumes. Update the documentation to explain this and cover the additional fields this exposes. Ref: #24797 Ref: https://hashicorp.atlassian.net/browse/NET-11482 Co-authored-by: Aimee Ukasick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job specification's
volume
block can claim either static or dynamic host volumes. Update the documentation to explain this and cover the additional fields this exposes.Ref: #24797
Ref: https://hashicorp.atlassian.net/browse/NET-11482