Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic host volumes: plugin spec tweaks #24848

Merged
merged 3 commits into from
Jan 13, 2025
Merged

dynamic host volumes: plugin spec tweaks #24848

merged 3 commits into from
Jan 13, 2025

Conversation

gulducat
Copy link
Member

Some plugin spec changes based on recent discussion.

  • All env prefixed with DHV_
  • Add: DHV_VOLUME_ID, DHV_PLUGIN_DIR
  • 5 second timeout for fingerprint operation

Notice to anyone using the example-plugin-mkfs demo plugin: you'll need to copy this changed version of it.

@gulducat gulducat added this to the 1.10.0 milestone Jan 13, 2025
@gulducat gulducat requested review from a team as code owners January 13, 2025 19:40
tgross
tgross approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gulducat gulducat merged commit 985eb53 into main Jan 13, 2025
37 checks passed
@gulducat gulducat deleted the dhv-plugin-spec-tweaks branch January 13, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@Juanadelacuesta Juanadelacuesta Awaiting requested review from Juanadelacuesta

Assignees
No one assigned
Labels
theme/storage type/enhancement
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gulducat @tgross