agent: Fix a bug where all syslog lines are notice when using JSON #24865
+232
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent syslog write handler was unable to handle JSON log lines correctly, meaning all syslog entries when using JSON log format showed as NOTICE level.
This change adds a new handler to the Nomad agent which can parse JSON log lines and correctly understand the expected log level entry.
The change also removes the use of a filter from the default log format handler. This is not needed as the logs are fed into the syslog handler via hclog, which is responsible for level filtering.
Testing & Reproduction steps
Running on a Linux workstation (Ubuntu 24.04) I added the following lines to the
/etc/rsyslog.conf
before restarting rsyslog viasudo service rsyslog restart
.I then ran Nomad via
sudo -i nomad agent -dev -log-json -log-level=<LEVEL> -config=/home/jrasell/config.hcl
using the following configuration:Links
Jira: https://hashicorp.atlassian.net/browse/NET-11973
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.