Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document required name for expose=true check #9691

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

krishicks
Copy link
Contributor

I followed #7709 when trying to reproduce this. I wasn't able to confirm that name needs to be set on both service and check; it appeared only to be required on check (as the service gets a name by default).

@krishicks krishicks merged commit af34ccc into master Dec 18, 2020
@krishicks krishicks deleted the hicks/check branch December 18, 2020 22:34
@holtwilkins
Copy link
Contributor

holtwilkins commented Jan 15, 2021

Hey @shoenig & @krishicks , is this actually correct? I just tested (with Nomad 1.0.2) an http check on a connect-enabled service, and set expose to true on the check but left name blank. It looks like I get a name like this by default "service: \"<The service's name here>\" check"

Note also in this case that I'm setting the service name explicitly, and not using the default one.

@krishicks
Copy link
Contributor Author

It possibly comes down to default name collision avoidance: if you set the service name, you don't need to set the check name, but if you don't set the service name, you do need to set the check name. 😞

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants