refactor: update alpine example #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
reviewed
Oct 2, 2024
tenthirtyam
requested changes
Oct 2, 2024
tenthirtyam
changed the title
|
Hi Brent! Wanted to check in and see if you are planning to update this PR. |
|
Yes, I'm still planning to see it through. My initial version was a straight update to the existing example. If you'd prefer a refactor (as discussed), I'll need some more time to complete that. I tore down my lab a little while ago 😬 |
Co-authored-by: Ryan Johnson <[email protected]>
Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
alpine-example-update
branch
from
1788ab7 to
5019972
Compare
tenthirtyam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update has been tested to successfully build Alpine 3.20.3 and execute the included
lscommand over ssh.