Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding name option for output command. #256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rambabuiitk
Copy link
Contributor

Updated tests

@rambabuiitk
Copy link
Contributor Author

@radeksimko As discuss separated the output option to this PR...Wondering if I could get a review for this

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rambabuiitk
This looks reasonable in principle, but unfortunately as you noticed the JSON output for output -json NAME differs significantly from output -json in that it doesn't contain any metadata about the type or sensitivity.

Therefore I'm afraid this is unsuitable for integration into the existing Output() interface.

The JSON output of terraform output -json is also now considered protected under Terraform v1 guarantees, so unlikely to change until at least v2.


Do you mind describing the use case which isn't served by the existing Output() / output -json and map key access?

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants