Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_emrserverless_application #37889

Merged

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #34377

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented Jun 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emrserverless Issues and PRs that pertain to the emrserverless service. labels Jun 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 8, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner July 16, 2024 17:53
@ewbankkit ewbankkit self-assigned this Jul 16, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRServerlessApplication_' PKG=emrserverless ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/emrserverless/... -v -count 1 -parallel 3  -run=TestAccEMRServerlessApplication_ -timeout 360m
=== RUN   TestAccEMRServerlessApplication_basic
=== PAUSE TestAccEMRServerlessApplication_basic
=== RUN   TestAccEMRServerlessApplication_arch
=== PAUSE TestAccEMRServerlessApplication_arch
=== RUN   TestAccEMRServerlessApplication_releaseLabel
=== PAUSE TestAccEMRServerlessApplication_releaseLabel
=== RUN   TestAccEMRServerlessApplication_initialCapacity
=== PAUSE TestAccEMRServerlessApplication_initialCapacity
=== RUN   TestAccEMRServerlessApplication_imageConfiguration
=== PAUSE TestAccEMRServerlessApplication_imageConfiguration
=== RUN   TestAccEMRServerlessApplication_interactiveConfiguration
=== PAUSE TestAccEMRServerlessApplication_interactiveConfiguration
=== RUN   TestAccEMRServerlessApplication_maxCapacity
=== PAUSE TestAccEMRServerlessApplication_maxCapacity
=== RUN   TestAccEMRServerlessApplication_network
=== PAUSE TestAccEMRServerlessApplication_network
=== RUN   TestAccEMRServerlessApplication_disappears
=== PAUSE TestAccEMRServerlessApplication_disappears
=== RUN   TestAccEMRServerlessApplication_tags
=== PAUSE TestAccEMRServerlessApplication_tags
=== CONT  TestAccEMRServerlessApplication_basic
=== CONT  TestAccEMRServerlessApplication_interactiveConfiguration
=== CONT  TestAccEMRServerlessApplication_initialCapacity
--- PASS: TestAccEMRServerlessApplication_interactiveConfiguration (89.74s)
=== CONT  TestAccEMRServerlessApplication_releaseLabel
--- PASS: TestAccEMRServerlessApplication_basic (71.72s)
=== CONT  TestAccEMRServerlessApplication_disappears
--- PASS: TestAccEMRServerlessApplication_initialCapacity (77.77s)
=== CONT  TestAccEMRServerlessApplication_tags
--- PASS: TestAccEMRServerlessApplication_releaseLabel (76.64s)
=== CONT  TestAccEMRServerlessApplication_network
--- PASS: TestAccEMRServerlessApplication_network (80.65s)
=== CONT  TestAccEMRServerlessApplication_maxCapacity
--- PASS: TestAccEMRServerlessApplication_tags (83.35s)
=== CONT  TestAccEMRServerlessApplication_imageConfiguration
--- PASS: TestAccEMRServerlessApplication_disappears (129.45s)
=== CONT  TestAccEMRServerlessApplication_arch
--- PASS: TestAccEMRServerlessApplication_maxCapacity (77.05s)
--- PASS: TestAccEMRServerlessApplication_arch (76.80s)
--- PASS: TestAccEMRServerlessApplication_imageConfiguration (600.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	766.572s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7cb27e3 into hashicorp:main Jul 16, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 16, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emrserverless Issues and PRs that pertain to the emrserverless service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Adding recently added Interactive Endpoint on AWS EMR Serverless Application
3 participants