Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_vpclattice_listener #37964

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jun 13, 2024

Description

Relations

Closes #37858

References

Output from Acceptance Testing

% make testacc TESTS=TestAccVPCLatticeListener_forwardTLSPassthrough PKG=vpclattice
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeListener_forwardTLSPassthrough'  -timeout 360m
=== RUN   TestAccVPCLatticeListener_forwardTLSPassthrough
=== PAUSE TestAccVPCLatticeListener_forwardTLSPassthrough
=== CONT  TestAccVPCLatticeListener_forwardTLSPassthrough
--- PASS: TestAccVPCLatticeListener_forwardTLSPassthrough (89.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	107.095s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpclattice Issues and PRs that pertain to the vpclattice service. labels Jun 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 13, 2024
@justinretzolk justinretzolk added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 14, 2024
@nikhil-goenka nikhil-goenka marked this pull request as ready for review June 14, 2024 20:42
@nikhil-goenka nikhil-goenka requested a review from a team as a code owner June 14, 2024 20:42
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jun 14, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 26, 2024
@ewbankkit ewbankkit self-assigned this Jul 16, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeListener_' PKG=vpclattice ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeListener_ -timeout 360m
=== RUN   TestAccVPCLatticeListener_defaultActionUpdate
=== PAUSE TestAccVPCLatticeListener_defaultActionUpdate
=== RUN   TestAccVPCLatticeListener_fixedResponseHTTP
=== PAUSE TestAccVPCLatticeListener_fixedResponseHTTP
=== RUN   TestAccVPCLatticeListener_fixedResponseHTTPS
=== PAUSE TestAccVPCLatticeListener_fixedResponseHTTPS
=== RUN   TestAccVPCLatticeListener_forwardTLSPassthrough
=== PAUSE TestAccVPCLatticeListener_forwardTLSPassthrough
=== RUN   TestAccVPCLatticeListener_forwardHTTPTargetGroup
=== PAUSE TestAccVPCLatticeListener_forwardHTTPTargetGroup
=== RUN   TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== PAUSE TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== RUN   TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
=== PAUSE TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
=== RUN   TestAccVPCLatticeListener_disappears
=== PAUSE TestAccVPCLatticeListener_disappears
=== RUN   TestAccVPCLatticeListener_tags
=== PAUSE TestAccVPCLatticeListener_tags
=== CONT  TestAccVPCLatticeListener_defaultActionUpdate
=== CONT  TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== CONT  TestAccVPCLatticeListener_forwardTLSPassthrough
--- PASS: TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN (75.56s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_forwardTLSPassthrough (106.05s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPTargetGroup
--- PASS: TestAccVPCLatticeListener_defaultActionUpdate (116.06s)
=== CONT  TestAccVPCLatticeListener_disappears
--- PASS: TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort (74.86s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
--- PASS: TestAccVPCLatticeListener_forwardHTTPTargetGroup (69.32s)
=== CONT  TestAccVPCLatticeListener_tags
--- PASS: TestAccVPCLatticeListener_disappears (77.18s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups (84.85s)
=== CONT  TestAccVPCLatticeListener_fixedResponseHTTPS
--- PASS: TestAccVPCLatticeListener_tags (89.10s)
=== CONT  TestAccVPCLatticeListener_fixedResponseHTTP
--- PASS: TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort (74.96s)
--- PASS: TestAccVPCLatticeListener_fixedResponseHTTPS (74.28s)
--- PASS: TestAccVPCLatticeListener_fixedResponseHTTP (73.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	343.188s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0452bb5 into hashicorp:main Jul 16, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 16, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants