Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node options support for dedicated coordinator nodes. #40181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akshay2000
Copy link

Description

Amazon OpenSearch Service (AOS) now supports dedicated coordinator nodes. This PR adds the support to provision and manage the dedicated coordinator nodes in AOS domains.

Relations

Closes #40135

References

API documentation: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ClusterConfig.html

Output from Acceptance Testing

% make testacc TESTS=TestAccOpenSearchDomain_Cluster_dedicatedCoordinator package=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_Cluster_dedicatedCoordinator'  -timeout 360m
2024/11/19 10:37:54 Initializing Terraform AWS Provider...
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedCoordinator (4000.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 4004.360s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearch Issues and PRs that pertain to the opensearch service. needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @akshay2000 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@akshay2000 akshay2000 marked this pull request as ready for review November 19, 2024 08:30
@akshay2000 akshay2000 requested a review from a team as a code owner November 19, 2024 08:30
@dubesar
Copy link

dubesar commented Nov 19, 2024

LGTM, Approved.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: OpenSearch Coordinator Node Options
3 participants