Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add hidden_sagemaker_image_version_aliases to sagemaker domain resource #40186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Enhancement] add hidden_sagemaker_image_version_aliases to sagemaker domain resource #40186

wants to merge 3 commits into from

Conversation

thiennguyen56
Copy link
Contributor

@thiennguyen56 thiennguyen56 commented Nov 19, 2024 •
edited
Loading

Description

Adding hidden_sagemaker_image_version_aliases option to the sagemaker domain resource
Adding acceptance tests for enhancement
Updating changelog and documents regarding changes

Relations

Closes #39876

References

Output from Acceptance Testing

% make testacc TESTS='TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenImageVersionAliases' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenImageVersionAliases'  -timeout 360m
2024/11/19 22:48:24 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenImageVersionAliases
--- PASS: TestAccSageMaker_serial (282.69s)
    --- PASS: TestAccSageMaker_serial/Domain (282.69s)
        --- PASS: TestAccSageMaker_serial/Domain/studioWebPortalSettings_hiddenImageVersionAliases (282.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  282.917s
...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
@thiennguyen56 thiennguyen56 force-pushed the r-aws_sagemaker_domain_add_options branch from aa8aac8 to 25b020d Compare November 19, 2024 15:47
@thiennguyen56 thiennguyen56 marked this pull request as ready for review November 19, 2024 16:14
@thiennguyen56 thiennguyen56 requested a review from a team as a code owner November 19, 2024 16:14
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
DrFaust92
DrFaust92 reviewed Jan 12, 2025
View reviewed changes
.changelog/40186.txt
@@ -0,0 +1,3 @@
```release-note:enhancement
resources/aws_sagemaker_domain: Add `hidden_sagemaker_image_version_aliases` argument
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to default_user_settings.studio_web_portal_settings. hidden_sagemaker_image_version_aliases

@DrFaust92
Copy link
Collaborator

thiennguyen56 looks good, this param is also passed to use_profile resource and it uses the same expand function, can we add it there as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrFaust92 DrFaust92 DrFaust92 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_sagemaker_domain add Hidden Image Versions options to the studio_web_portal_settings
3 participants
@thiennguyen56 @DrFaust92 @justinretzolk