Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: r/aws_glue_catalog_table_optimizer Add configuration support for retention and orphan_file_deletion types #40199

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ryanmiville
Copy link

Description

  • add configuration for retention type to aws_glue_catalog_table_optimizer
  • add configuration for orphan_file_deletion type to aws_glue_catalog_table_optimizer
  • add new aws_glue_catalog_table_optimizer acceptance tests for new configuration types
  • update aws_glue_catalog_table_optimizer documentation for new configuration types

Relations

Closes #39405

References

Output from Acceptance Testing

% make testacc TESTS=TestAccGlueCatalogTableOptimizer PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTableOptimizer'  -timeout 360m
2024/11/19 16:46:56 Initializing Terraform AWS Provider...
=== RUN   TestAccGlueCatalogTableOptimizer_RetentionConfiguration
--- PASS: TestAccGlueCatalogTableOptimizer_RetentionConfiguration (39.72s)
=== RUN   TestAccGlueCatalogTableOptimizer_DeleteOrphanFileConfiguration
--- PASS: TestAccGlueCatalogTableOptimizer_DeleteOrphanFileConfiguration (38.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	94.213s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ryanmiville 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ryanmiville ryanmiville changed the title [Enhancement]: r/aws_glue_catalog_table_optimizer Add support for expiring snapshots and orphan file deletion [Enhancement]: r/aws_glue_catalog_table_optimizer Add configuration support for retention and orphan_file_deletion types Nov 19, 2024
@ryanmiville ryanmiville marked this pull request as ready for review November 19, 2024 22:17
@ryanmiville ryanmiville requested a review from a team as a code owner November 19, 2024 22:17
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_glue_catalog_table_optimizer Add support for expiring snapshots and orphan file deletion
2 participants