Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_service: add availability_zone_rebalancing attribute #40225

Merged
merged 13 commits into from
Nov 21, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 20, 2024

Description

Add support for availability_zone_rebalancing to aws_ecs_service

Relations

Closes #40221

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccECSService_' PKG=ecs

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSService_ -timeout 360m
2024/11/20 16:09:22 Initializing Terraform AWS Provider...
--- PASS: TestAccECSService_DeploymentControllerType_external (55.67s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (73.99s)
--- PASS: TestAccECSService_clusterName (74.11s)
--- PASS: TestAccECSService_basic (83.60s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (83.79s)
--- PASS: TestAccECSService_DeploymentValues_basic (83.91s)
--- PASS: TestAccECSService_executeCommand (85.20s)
--- PASS: TestAccECSService_alarmsUpdate (95.07s)
--- PASS: TestAccECSService_alarmsAdd (95.07s)
--- PASS: TestAccECSService_AvailabilityZoneRebalancing (100.36s)
--- PASS: TestAccECSService_forceNewDeployment (117.07s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (124.79s)
--- PASS: TestAccECSService_iamRole (31.27s)
--- PASS: TestAccECSService_Tags_propagate (78.15s)
--- PASS: TestAccECSService_Tags_managed (59.85s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (61.08s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (70.53s)
--- PASS: TestAccECSService_ServiceRegistries_container (158.90s)
--- PASS: TestAccECSService_Tags_basic (91.38s)
--- PASS: TestAccECSService_familyAndRevision (68.11s)
--- PASS: TestAccECSService_PlacementStrategy_missing (1.03s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (170.48s)
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (61.63s)
--- PASS: TestAccECSService_ServiceConnect_remove (195.85s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (81.79s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (120.60s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (130.56s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (38.95s)
--- PASS: TestAccECSService_VolumeConfiguration_update (122.19s)
--- PASS: TestAccECSService_PlacementConstraints_basic (79.62s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (69.70s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (119.80s)
--- PASS: TestAccECSService_loadBalancerChanges (281.51s)
--- PASS: TestAccECSService_alb (298.42s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (165.89s)
--- PASS: TestAccECSService_ServiceConnect_full (166.11s)
--- PASS: TestAccECSService_multipleTargetGroups (301.42s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (145.49s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (37.97s)
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (166.21s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (312.70s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (69.63s)
--- PASS: TestAccECSService_ServiceConnect_basic (148.13s)
--- PASS: TestAccECSService_ServiceRegistries_removal (152.43s)
--- PASS: TestAccECSService_ServiceRegistries_basic (141.28s)
--- PASS: TestAccECSService_disappears (189.51s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (116.54s)
--- PASS: TestAccECSService_PlacementStrategy_basic (96.22s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (224.74s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (320.30s)
--- PASS: TestAccECSService_basicImport (194.65s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (463.67s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (182.69s)
--- PASS: TestAccECSService_ServiceRegistries_changes (282.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	538.584s
% make testacc TESTARGS='-run=TestAccECSServiceDataSource_basic' PKG=ecs

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSServiceDataSource_basic -timeout 360m
2024/11/20 17:07:30 Initializing Terraform AWS Provider...
--- PASS: TestAccECSServiceDataSource_basic (61.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	68.386s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 20, 2024
@johnsonaj johnsonaj changed the title F ecs az rebalancing r/aws_ecs_service: add availability_zone_rebalancing attribute Nov 20, 2024
@johnsonaj johnsonaj marked this pull request as ready for review November 20, 2024 22:54
@johnsonaj johnsonaj requested a review from a team as a code owner November 20, 2024 22:54
jar-b
jar-b previously approved these changes Nov 21, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ecs TESTS=TestAccECSService_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_'  -timeout 360m

--- PASS: TestAccECSService_iamRole (47.19s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (51.53s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_clusterName (71.72s)
=== CONT  TestAccECSService_VolumeConfiguration_throughputTypeChange
--- PASS: TestAccECSService_deploymentCircuitBreaker (71.84s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_replicaSchedulingStrategy (72.58s)
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (72.91s)
=== CONT  TestAccECSService_VolumeConfiguration_tagSpecifications
--- PASS: TestAccECSService_basic (82.05s)
=== CONT  TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_VolumeConfiguration_basic (83.62s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.03s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (59.79s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_forceNewDeploymentTriggers (111.98s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_forceNewDeployment (112.79s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_familyAndRevision (67.23s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (131.61s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (60.38s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_DeploymentValues_basic (63.14s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_LaunchTypeFargate_basic (142.39s)
=== CONT  TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_DeploymentControllerType_external (33.25s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_ServiceRegistries_basic (151.21s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_alarmsUpdate (70.88s)
=== CONT  TestAccECSService_AvailabilityZoneRebalancing
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (83.14s)
=== CONT  TestAccECSService_Tags_managed
--- PASS: TestAccECSService_ServiceRegistries_container (161.82s)
=== CONT  TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_alarmsAdd (79.91s)
=== CONT  TestAccECSService_Tags_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (69.39s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (182.34s)
=== CONT  TestAccECSService_executeCommand
--- PASS: TestAccECSService_VolumeConfiguration_update (111.62s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (38.77s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_Tags_managed (59.82s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_PlacementStrategy_basic (97.20s)
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
--- PASS: TestAccECSService_Tags_propagate (78.51s)
=== CONT  TestAccECSService_ServiceRegistries_removal
--- PASS: TestAccECSService_LaunchTypeEC2_network (106.73s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (60.27s)
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_Tags_basic (81.19s)
=== CONT  TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSService_AvailabilityZoneRebalancing (96.32s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_executeCommand (69.95s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (142.07s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (122.88s)
--- PASS: TestAccECSService_alb (281.24s)
--- PASS: TestAccECSService_multipleTargetGroups (283.71s)
--- PASS: TestAccECSService_loadBalancerChanges (284.35s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (285.18s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (330.35s)
--- PASS: TestAccECSService_ServiceConnect_remove (189.71s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (209.41s)
--- PASS: TestAccECSService_ServiceConnect_full (166.45s)
--- PASS: TestAccECSService_disappears (189.85s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (174.17s)
--- PASS: TestAccECSService_ServiceConnect_basic (148.10s)
--- PASS: TestAccECSService_ServiceRegistries_removal (152.19s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (165.78s)
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (165.43s)
--- PASS: TestAccECSService_basicImport (184.31s)
--- PASS: TestAccECSService_ServiceRegistries_changes (273.10s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (467.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        587.146s

@johnsonaj
Copy link
Contributor Author

@dani-chmb thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit d26cf72 into main Nov 21, 2024
41 of 42 checks passed
@johnsonaj johnsonaj deleted the f-ecs_az_rebalancing branch November 21, 2024 15:36
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 21, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 21, 2024
Copy link

This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Availability Zone Rebalancing to AWS ECS Service
3 participants