Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws_mwaa_environment): add support of micro environment #40244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeremychauvet
Copy link
Contributor

@jeremychauvet jeremychauvet commented Nov 21, 2024

Description

This PR introduce support of 'micro' environment class on MWAA (Managed Workflow for Apache Airflow).

NOTE: Rather than create a new test for this specific type of environment, I've modified the configuration of the basic test to use it, aiming to keep tests simple to maintain and reduce costs.

Relations

Closes #40231

References

https://aws.amazon.com/blogs/big-data/introducing-amazon-mwaa-micro-environments-for-apache-airflow/

Output from Acceptance Testing

make testacc TESTS=TestAccMWAAEnvironment_basic PKG=mwaa
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_basic'  -timeout 360m
2024/11/21 17:14:02 Initializing Terraform AWS Provider...
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_basic
--- PASS: TestAccMWAAEnvironment_basic (2620.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       2621.024s

@jeremychauvet jeremychauvet requested a review from a team as a code owner November 21, 2024 17:09
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mwaa Issues and PRs that pertain to the mwaa service. needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/mwaa Issues and PRs that pertain to the mwaa service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for MWAA micro environments
1 participant