Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: fix formatting in post_publish shell script #40245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

.github/workflows: fix formatting in post_publish shell script #40245

wants to merge 1 commit into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 21, 2024 •
edited
Loading

Description

A missed quote caused the script to fail during the v5.77.0 release.

/home/runner/work/_temp/b9a14e53-10ad-497f-a91b-d57575e541f4.sh: line 12: unexpected EOF while looking for matching `"'
Error: Process completed with exit code 2.

Ref: https://github.com/hashicorp/terraform-provider-aws/actions/runs/11959899920/job/33342735174

Relations

Relates #39964

@jar-b
.github/workflows: fix formatting in post_publish shell script
83c4c5f 
A missed quote caused the script to fail during the `v5.77.0` release.

```
/home/runner/work/_temp/b9a14e53-10ad-497f-a91b-d57575e541f4.sh: line 12: unexpected EOF while looking for matching `"'
Error: Process completed with exit code 2.
```
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 21, 2024
ewbankkit
ewbankkit approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-b @ewbankkit