r/chatbot: Fix SNS topic ARNs ordering in Slack channel configuration #40253
+44
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency in the aws_chatbot_slack_channel_configuration resource where it unnecessarily triggers plan changes when SNS topics are returned in a different order from the AWS API.
The fix implements sorting of SNS topic ARNs before comparison in the slackChannelConfigurationHasChanges function, ensuring that the order of topics doesn't trigger unnecessary updates.
Before this fix:
Plan would show changes when AWS returns topics in different order:
After this fix:
No changes shown when only order differs:
Fixes #39025