Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer export tagging functions #41797

Merged
merged 6 commits into from
Mar 28, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No longer exports most keyValueTags functions
  • Loading branch information
gdavison committed Mar 8, 2025
commit 64c0eb202e56ac9144ae59eb52df6c25155063ca
2 changes: 1 addition & 1 deletion internal/generate/tags/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const (
defaultCreateTagsFunc = "createTags"
defaultGetTagFunc = "findTag"
defaultGetTagsInFunc = "getTagsIn"
defaultKeyValueTagsFunc = "KeyValueTags"
defaultKeyValueTagsFunc = "keyValueTags"
defaultListTagsFunc = "listTags"
defaultSetTagsOutFunc = "setTagsOut"
defaultTagsFunc = "Tags"
Expand Down
8 changes: 4 additions & 4 deletions internal/service/accessanalyzer/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/service/acm/certificate_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func dataSourceCertificateRead(ctx context.Context, d *schema.ResourceData, meta
return sdkdiag.AppendErrorf(diags, "listing tags for ACM Certificate (%s): %s", certificateARN, err)
}

if !tags.ContainsAll(KeyValueTags(ctx, tagsToMatch)) {
if !tags.ContainsAll(keyValueTags(ctx, tagsToMatch)) {
continue
}
}
Expand Down
8 changes: 4 additions & 4 deletions internal/service/acm/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/acmpca/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/amp/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/amplify/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/apigateway/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/service/apigatewayv2/apis_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func dataSourceAPIsRead(ctx context.Context, d *schema.ResourceData, meta interf
continue
}

if len(tagsToMatch) > 0 && !KeyValueTags(ctx, api.Tags).IgnoreAWS().IgnoreConfig(ignoreTagsConfig).ContainsAll(tagsToMatch) {
if len(tagsToMatch) > 0 && !keyValueTags(ctx, api.Tags).IgnoreAWS().IgnoreConfig(ignoreTagsConfig).ContainsAll(tagsToMatch) {
continue
}

Expand Down
8 changes: 4 additions & 4 deletions internal/service/apigatewayv2/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/appautoscaling/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/appconfig/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/appfabric/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/appflow/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/service/appintegrations/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading