Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_vpc_endpoint_associations datasource #41918

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Mar 19, 2025

Description

Add aws_vpc_endpoint_associations datasource to allow listing of the resources associated with a VPC Endpoint.

Relations

Closes #41859
Closes #41765

References

Output from Acceptance Testing

% make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCEndpointAssociationsDataSource PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCEndpointAssociationsDataSource'  -timeout 360m -vet=off
2025/03/19 15:50:20 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointAssociationsDataSource_basic
=== PAUSE TestAccVPCEndpointAssociationsDataSource_basic
=== RUN   TestAccVPCEndpointAssociationsDataSource_serviceNetwork
=== PAUSE TestAccVPCEndpointAssociationsDataSource_serviceNetwork
=== CONT  TestAccVPCEndpointAssociationsDataSource_basic
=== CONT  TestAccVPCEndpointAssociationsDataSource_serviceNetwork
--- PASS: TestAccVPCEndpointAssociationsDataSource_basic (113.52s)
--- PASS: TestAccVPCEndpointAssociationsDataSource_serviceNetwork (120.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        126.698s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Mar 19, 2025
@drewtul drewtul force-pushed the vpc-lattice-resource-endpoints branch from a302fdc to 4132017 Compare March 19, 2025 15:32
@drewtul drewtul changed the title Add vpc_endpoint_associations datasource Add aws_vpc_endpoint_associations datasource Mar 19, 2025
@drewtul drewtul marked this pull request as ready for review March 19, 2025 17:05
@drewtul drewtul requested a review from a team as a code owner March 19, 2025 17:05
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_vpc_endpoint_associations [Bug]: Service Network Type EndPoint can't lookup DnsEntry
2 participants