r/aws_elasticache_replication_group: retry InvalidReplicationGroupStateFault errors in tag operations
#41954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
service/elasticache
jar-b
force-pushed
the
b-elasticache-tags-retry
branch
from
a73e24f to
b08d680
Compare
jar-b
added
the
regression
This function is a generic version of `RetryWhenIsAErrorMessageContains` which eliminates the need to perform a type assertion on the returned result.
These options will allow for wrapping list, tag, and untag operations in retry logic for services which may need to for certain resource types.
…ateFault` errors in tag operations This fixes a regression introduced during the AWS SDK for Go V2 migration of Elasticache. Previously the generated tagging logic for AWS SDK for Go V1 included retry logic around the list, tag, and untag operations. These were inadvertently dropped during the SDK migration, and have been added back here using the AWS SDK V2 form of retry handling which accepts error types as an argument. As with the previous implementation tagging operations will have a retry timeout of 15 minutes.
jar-b
force-pushed
the
b-elasticache-tags-retry
branch
from
b08d680 to
a3adf5f
Compare
ewbankkit
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_tag\|TestAccElastiCacheReplicationGroup_Tag' PKG=elasticache ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/elasticache/... -v -count 1 -parallel 3 -run=TestAccElastiCacheReplicationGroup_tag\|TestAccElastiCacheReplicationGroup_Tag -timeout 360m -vet=off
2025/03/24 16:40:28 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheReplicationGroup_tags
=== PAUSE TestAccElastiCacheReplicationGroup_tags
=== RUN TestAccElastiCacheReplicationGroup_TagWithOtherModification_version
=== PAUSE TestAccElastiCacheReplicationGroup_TagWithOtherModification_version
=== RUN TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters
=== PAUSE TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters
=== CONT TestAccElastiCacheReplicationGroup_tags
=== CONT TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters
=== CONT TestAccElastiCacheReplicationGroup_TagWithOtherModification_version
--- PASS: TestAccElastiCacheReplicationGroup_tags (959.06s)
--- PASS: TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters (1265.09s)
--- PASS: TestAccElastiCacheReplicationGroup_TagWithOtherModification_version (1416.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 1421.887s
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v5.93.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression introduced during the AWS SDK for Go V2 migration of Elasticache. Previously, the generated tagging logic for AWS SDK for Go V1 included retry logic around the list, tag, and untag operations. These were inadvertently dropped during the SDK migration, and have been added back here using the AWS SDK V2 form of retry handling which accepts error types as an argument. As with the previous implementation tagging operations will have a retry timeout of 15 minutes.
Relations
Closes #35952
Closes #40948
Relates #36310 (Initial implementation of tag operation retries,
v5.41.0)Relates #38046 (AWS SDK migration which removed retries and caused the regression,
v5.59.0)Output from Acceptance Testing