Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/seo updates #36083

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Docs/seo updates #36083

merged 14 commits into from
Dec 16, 2024

Conversation

trujillo-adam
Copy link
Contributor

Update meta titles, descriptions, and H1 titles for SEO.

Copy link
Contributor

The equivalence tests will be updated. Please verify the changes here.

@trujillo-adam trujillo-adam marked this pull request as ready for review November 23, 2024 00:13
@trujillo-adam trujillo-adam requested review from a team as code owners November 23, 2024 00:13
Copy link
Contributor

The equivalence tests will be updated. Please verify the changes here.

BrianMMcClain
BrianMMcClain previously approved these changes Nov 27, 2024
Copy link
Contributor

@BrianMMcClain BrianMMcClain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing I'd raise I thought we had landed on using sentence case for titles rather than title case, but I might be wrong.

website/docs/cli/auth/index.mdx Outdated Show resolved Hide resolved
@@ -1,16 +1,22 @@
---
page_title: Writing and Modifying Code - Terraform CLI
page_title: Write and modify Terrafrom configuration from the CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this page originally included "write", but I'd argue all o these commands modify existing configuration rather than create new configuration. My vote would be something like "Format and validate configuration".

@@ -1,12 +1,10 @@
---
page_title: Initializing Working Directories - Terraform CLI
page_title: Initialize the Terraform working directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've included the word "overview" in other index pages, do we want the same here?

Copy link
Contributor

github-actions bot commented Dec 9, 2024

The equivalence tests will be updated. Please verify the changes here.

description: >-
Documentation about the login and logout commands that help automate getting
an API token for your HCP Terraform account.
Use the terraform login and terraform logout commands get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these commands have backticks?

---

# Import
# Import existing resources overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Import existing resources overview
# Import existing resources

ritsok
ritsok previously approved these changes Dec 13, 2024
Copy link
Contributor

@ritsok ritsok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still pending the changes for quoting commands in page titles, but I've reviewed the rest. Some were clarity/style edits, take what you like. Thanks!

Copy link
Contributor

@ritsok ritsok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@@ -1,40 +1,30 @@
---
page_title: 'Command: providers schema'
page_title: terraform providers schema command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: terraform providers schema command
page_title: terraform providers schema command reference

page_title: Inspecting State - Terraform CLI
description: Commands that allow you to read and update state.
page_title: Inspect Terraform state
description: The `terraform state` group of commands help you inspect Terraform state. Learn how inspecting Terraform state can help you read and update state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `terraform state` group of commands help you inspect Terraform state. Learn how inspecting Terraform state can help you read and update state.
description: The `terraform state` group of commands let you inspect Terraform state.

@@ -1,12 +1,11 @@
---
page_title: 'Command: workspace select'
description: The terraform workspace select command is used to choose a workspace.
page_title: terraform workspace select` command reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: terraform workspace select` command reference
page_title: terraform workspace select command reference

The `terraform untaint` command tells Terraform that an object is functioning
correctly, even though its creation failed or it was previously manually
marked as degraded.
The `terraform untaint` command removes the `tainted` status from infrastructure objects tracked in the Terraform state data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `terraform untaint` command removes the `tainted` status from infrastructure objects tracked in the Terraform state data.
The `terraform untaint` command removes the `tainted` market from infrastructure objects tracked in Terraform state.

description: |-
The `terraform taint` command informs Terraform that a particular object
is damaged or degraded.
The `terraform taint` command marks specified objects in the Terraform state as tainted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `terraform taint` command marks specified objects in the Terraform state as tainted.
The `terraform taint` command marks specified objects in the Terraform state as tainted, prompting Terraform to recreate the resource in the next run.

page_title: 'Command: state push'
description: The `terraform state push` command pushes items to the Terraform state.
page_title: terraform state push command reference
description: The `terraform state push` command uploads a state file to the Terraform state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `terraform state push` command uploads a state file to the Terraform state.
description: The `terraform state push` command uploads a state file to the configured state storage location.

description: >-
Commands that allow you to manage the way that resources are tracked in state.
They are helpful when you move or change resources.
Terraform state commands can move and remove resources and transfer existing resources to a different provider. Learn how about changing or moving resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Terraform state commands can move and remove resources and transfer existing resources to a different provider. Learn how about changing or moving resources.
Terraform state commands can move and remove resources and transfer existing resources to a different provider.

page_title: Forcing Re-creation of Resources - Terraform CLI
description: Commands that allow you to destroy and re-create resources manually.
page_title: Recreate resources
description: The -replace flag and taint command help you replace infrastructure objects. Learn how the -replace flag and taint command can help you recreate resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The -replace flag and taint command help you replace infrastructure objects. Learn how the -replace flag and taint command can help you recreate resources.
description: The -replace flag and taint command let you recreate infrastructure objects.

@@ -1,43 +1,37 @@
---
page_title: Testing Terraform - Terraform CLI
page_title: Testing features in Terraform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Testing features in Terraform
page_title: Testing your Terraform configuration

correctness in your infrastructure.
---

# Testing Terraform
# Testing features in Terraform overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Testing features in Terraform overview
# Testing Terraform configuration overview

otherwise it reads as if we're testing the features themselves

EnMod
EnMod previously approved these changes Dec 16, 2024
Copy link

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a Web Presence perspective, deferring to others for content approval 👍

@trujillo-adam trujillo-adam merged commit 1680b0d into main Dec 16, 2024
8 checks passed
@trujillo-adam trujillo-adam deleted the docs/seo-updates branch December 16, 2024 19:30
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants