Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-2745: Revert specifying revision for crc32c crate #4527

Merged

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

crc32c released a new version

🔗 Related links

@TimDiekmann TimDiekmann requested a review from vilkinsons May 28, 2024 07:56
@TimDiekmann TimDiekmann enabled auto-merge May 28, 2024 07:56
@github-actions github-actions bot added the area/deps Relates to third-party dependencies (area) label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.04%. Comparing base (c68c246) to head (cde9776).
Report is 1664 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4527      +/-   ##
==========================================
- Coverage   21.11%   21.04%   -0.08%     
==========================================
  Files         459      460       +1     
  Lines       15242    15289      +47     
  Branches     2273     2283      +10     
==========================================
- Hits         3218     3217       -1     
- Misses      11983    12031      +48     
  Partials       41       41              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.81% <ø> (-0.03%) ⬇️
apps.hash-api 0.00% <ø> (ø)
blockprotocol.type-system 47.36% <ø> (ø)
deer 26.66% <ø> (ø)
error-stack 76.61% <ø> (ø)
local.hash-backend-utils 4.26% <ø> (-0.04%) ⬇️
local.hash-isomorphic-utils 0.00% <ø> (ø)
local.hash-subgraph 17.93% <ø> (-0.19%) ⬇️
sarif 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$1.54 \mathrm{s} \pm 3.10 \mathrm{ms}\left({\color{red}452 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$53.0 \mathrm{ms} \pm 276 \mathrm{μs}\left({\color{gray}0.028 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$22.2 \mathrm{ms} \pm 142 \mathrm{μs}\left({\color{gray}3.99 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$78.5 \mathrm{ms} \pm 822 \mathrm{μs}\left({\color{red}6.16 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.2 \mathrm{ms} \pm 147 \mathrm{μs}\left({\color{gray}1.68 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.1 \mathrm{ms} \pm 177 \mathrm{μs}\left({\color{lightgreen}-11.067 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.3 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-11.390 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.7 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}-2.479 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.8 \mathrm{ms} \pm 204 \mathrm{μs}\left({\color{gray}-2.313 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$17.1 \mathrm{ms} \pm 186 \mathrm{μs}\left({\color{gray}-1.338 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$17.1 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{gray}-4.200 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.1 \mathrm{ms} \pm 175 \mathrm{μs}\left({\color{lightgreen}-8.890 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$17.1 \mathrm{ms} \pm 227 \mathrm{μs}\left({\color{lightgreen}-19.329 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.3 \mathrm{ms} \pm 236 \mathrm{μs}\left({\color{gray}-4.826 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$2.00 \mathrm{s} \pm 6.21 \mathrm{ms}\left({\color{gray}-1.788 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$1.07 \mathrm{s} \pm 4.86 \mathrm{ms}\left({\color{gray}-1.855 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$1.04 \mathrm{s} \pm 6.45 \mathrm{ms}\left({\color{lightgreen}-5.802 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$98.7 \mathrm{ms} \pm 811 \mathrm{μs}\left({\color{gray}-2.910 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$424 \mathrm{ms} \pm 3.71 \mathrm{ms}\left({\color{gray}-0.394 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$61.3 \mathrm{ms} \pm 458 \mathrm{μs}\left({\color{gray}-4.189 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$2.92 \mathrm{s} \pm 14.6 \mathrm{ms}\left({\color{gray}-0.343 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$998 \mathrm{ms} \pm 6.90 \mathrm{ms}\left({\color{gray}0.326 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$973 \mathrm{ms} \pm 3.18 \mathrm{ms}\left({\color{gray}-4.083 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$40.4 \mathrm{ms} \pm 261 \mathrm{μs}\left({\color{gray}-2.870 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$355 \mathrm{ms} \pm 1.46 \mathrm{ms}\left({\color{gray}-3.897 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$36.5 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-1.916 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.42 \mathrm{ms} \pm 9.45 \mathrm{μs}\left({\color{gray}-0.287 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1000 entities $$3.29 \mathrm{ms} \pm 18.5 \mathrm{μs}\left({\color{gray}0.057 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.62 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{gray}0.296 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.46 \mathrm{ms} \pm 15.8 \mathrm{μs}\left({\color{gray}-0.730 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.3 \mathrm{ms} \pm 153 \mathrm{μs}\left({\color{gray}-1.205 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.46 \mathrm{ms} \pm 12.1 \mathrm{μs}\left({\color{gray}-0.695 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.64 \mathrm{ms} \pm 23.4 \mathrm{μs}\left({\color{gray}3.09 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.76 \mathrm{ms} \pm 30.1 \mathrm{μs}\left({\color{red}5.15 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.51 \mathrm{ms} \pm 16.0 \mathrm{μs}\left({\color{gray}0.668 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.13 \mathrm{ms} \pm 16.4 \mathrm{μs}\left({\color{gray}-0.800 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.56 \mathrm{ms} \pm 14.7 \mathrm{μs}\left({\color{gray}1.36 \mathrm{\%}}\right) $$ Flame Graph

@TimDiekmann TimDiekmann added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit a0ea460 May 28, 2024
139 of 140 checks passed
@TimDiekmann TimDiekmann deleted the t/h-2745-revert-specifying-revision-for-crc32c-crate branch May 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area)
Development

Successfully merging this pull request may close these issues.

2 participants