Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support GHC 9.0 #1392

Closed
wants to merge 2 commits into from
Closed

support GHC 9.0 #1392

wants to merge 2 commits into from

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Feb 11, 2021

The code changes are due to simplified subsumption

TODO:

  • lots of dependencies are not yet updated on hackage
  • spec test suite of servant-http-streams fails
  • fix servant-quickcheck to work with http-client >= 0.7

I use this cabal.project.local: https://gist.github.com/amesgen/f9cd921b6cd8b39cd5f64f06c3bcf0d2

@akhesaCaro
Copy link
Contributor

Hi amesgen,

We changed the CI, could you rebase your branch to see if it passes the CI checks?

@amesgen
Copy link
Contributor Author

amesgen commented Mar 19, 2021

Added a (temporary) commit to also test GHC 9.0.1.

@amesgen
Copy link
Contributor Author

amesgen commented Mar 19, 2021

Uhhh, CI for GHC 9.0.1 passes except for this doctest error (EDIT see next comment):

src/Servant/API/ContentTypes.hs:123: failure in expression `:{
instance Accept HTML where
    contentType _ = "text" // "html" /: ("charset", "utf-8")
:}'
expected: 
 but got: ghc: panic! (the 'impossible' happened)
          ^
            (GHC version 9.0.1:
          \tlinkSomeBCOs: no break array
          
          Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

Maybe it is a good idea to migrate to cabal-docspec.

@amesgen
Copy link
Contributor Author

amesgen commented Mar 19, 2021

Ah, this is due to https://gitlab.haskell.org/ghc/ghc/-/issues/19460

GHC 9.0.1 has another serious bug (https://mail.haskell.org/pipermail/haskell-cafe/2021-March/133540.html), so let's wait for GHC 9.0.2, as this PR can't be merged either way as several dependencies are not yet updated.

@maksbotan
Copy link
Contributor

Hi!

Sorry I didn't look for existing PRs and made pretty much the same thing in #1409. Will wait for 9.0.2 with bugfixes.

@amesgen
Copy link
Contributor Author

amesgen commented May 9, 2021

Now depends on haskell-servant/servant-quickcheck#78 for http-client-0.7.* support.

@amesgen
Copy link
Contributor Author

amesgen commented Jun 24, 2021

Superseded by #1409

@amesgen amesgen closed this Jun 24, 2021
@amesgen amesgen deleted the ghc-9.0 branch June 24, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants