-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support GHC 9.0 #1392
support GHC 9.0 #1392
Conversation
Hi amesgen, We changed the CI, could you rebase your branch to see if it passes the CI checks? |
Added a (temporary) commit to also test GHC 9.0.1. |
Uhhh, CI for GHC 9.0.1 passes except for this doctest error (EDIT see next comment):
Maybe it is a good idea to migrate to cabal-docspec. |
Ah, this is due to https://gitlab.haskell.org/ghc/ghc/-/issues/19460 GHC 9.0.1 has another serious bug (https://mail.haskell.org/pipermail/haskell-cafe/2021-March/133540.html), so let's wait for GHC 9.0.2, as this PR can't be merged either way as several dependencies are not yet updated. |
Hi! Sorry I didn't look for existing PRs and made pretty much the same thing in #1409. Will wait for 9.0.2 with bugfixes. |
Now depends on haskell-servant/servant-quickcheck#78 for http-client-0.7.* support. |
Superseded by #1409 |
The code changes are due to simplified subsumption
TODO:
I use this
cabal.project.local
: https://gist.github.com/amesgen/f9cd921b6cd8b39cd5f64f06c3bcf0d2