Show constraint sources in dependency solver errors #10524
Conversation
9999years
force-pushed
the
dependency-provenance
branch
2 times, most recently
from
4811a3c
to
0c8471d
Compare
We have a lot of `showType` functions that are effectively a `Pretty` instance but less composable. Let's make them proper `Pretty` instances. Split off of haskell#10524
9999years
force-pushed
the
dependency-provenance
branch
9 times, most recently
from
9ebbba8
to
522bec9
Compare
cabal-testsuite/PackageTests/NewSdist/MultiTarget/all-test-sute.out
Outdated
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConstraintSource/SourceRepositoryPackage/cabal.out
Show resolved
Hide resolved
|
@jasagredo just a heads-up: on the last Cabal meeting @9999years asked to not comment on their PRs while a PR is in the draft mode. I remember it because I’m guilty in it more than many! |
9999years
force-pushed
the
dependency-provenance
branch
from
522bec9
to
e52d016
Compare
9999years
changed the title
9999years
force-pushed
the
dependency-provenance
branch
2 times, most recently
from
c10bd7d
to
9854c9d
Compare
|
Needs a release note. |
9999years
force-pushed
the
dependency-provenance
branch
from
9854c9d
to
9492b41
Compare
Before:
[__0] rejecting: memory-0.18.0 (constraint from user target requires ==0.17.0)
After:
[__0] rejecting: memory-0.18.0
(constraint from cabal.project requires ==0.17.0)
9999years
force-pushed
the
dependency-provenance
branch
from
9492b41
to
b27b413
Compare
|
Added a release note and tests, addressed comments. Should be ready to go! |
| import Text.PrettyPrint | ||
|
|
||
| -- | A package bundled with a `ConstraintSource`. | ||
| data WithConstraintSource pkg = |
There was a problem hiding this comment.
I see this type being used as WithContraintSource UserConstraint so I think pkg is not actually a pkg? i.e. constraintPackage is misnamed?
There was a problem hiding this comment.
Yeah, constraintPackage is often (but not always) a package. I wasn't sure of a better name for it. constraintInner, maybe? constraintConstraint is also somewhat misleadying, as it's a constraint source and not a UserConstraint itself...
There was a problem hiding this comment.
I renamed them, how do these look?
constraintPackage→constraintInnerconstraintConstraint→constraintSource
`constraintPackage` -> `constraintInner` `constraintConstraint` -> `constraintSource`
Before:
After:
First shot at #10519. Seems unavoidably large.
Builds off of #9578.
Future work: Propagate line numbers into these constraints!
Implementation strategy:
Propagate provenance (
ProjectConfigPath/ConstraintSource) into project config types (Distribution.Client.ProjectConfig,D.C.ProjectConfig.Legacy)Extract and attach that information in
D.C.ProjectConfig.findProjectPackagesAttach that information to
ProjectPackageLocation(returned fromfindProjectPackages). Note: Might be worth unifying that withPackageLocation, would make the new typePackageLocationProvenance.Use that information to write better
ConstraintSources into the solver; this is mostly implemented.Overall it seems like all the information exists, but it takes a lot of work to propagate it into the right parts of the system.