-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration guide for #9718 #10578
Conversation
Does this need a backport? Or do we always link |
PR haskell#9718 and related PRs reshuffled and refactored Cabal API. This patch adds a simple migration guide for Cabal library users. Authored-by: Maxim Ivanov
7614e7c
to
b4c1f10
Compare
Check commit by commit, GitHub rich diff gets confused and messes the diff up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor nitpick
Co-authored-by: Maxim Ivanov <[email protected]>
Only master, yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific! Thanks Francesco and Maxim!
Thanks for contributing this @ulidtko |
Ping @ulysses4ever, @Kleidukos, merge any soon? |
@ulidtko, thanks for the ping! The funny thing is, despite overwhelming support, we still lack the second review. Maybe @geekosaur?.. |
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).Thanks to the excellent doc contribution by @ulidtko in #10559.