Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 0.6 release #581

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Prepare 0.6 release #581

merged 6 commits into from
Nov 11, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Nov 10, 2020

  • i want to add screenshots for hlint and module plugins

@jneira jneira linked an issue Nov 10, 2020 that may be closed by this pull request
2020-11 monthly release #567
Closed
lukel97
lukel97 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukel97
Copy link
Collaborator

lukel97 commented Nov 11, 2020

@jneira Argh, looks like we got really unlucky and GitHub decided to break just as we were making the release: actions/upload-release-asset#68

@lukel97
Copy link
Collaborator

lukel97 commented Nov 11, 2020

Once it gets fixed on their end you can try deleting the tag and release and trying again

@jneira jneira merged commit a359337 into haskell:master Nov 11, 2020
@jneira
Copy link
Member Author

jneira commented Nov 11, 2020

oh, i thought that rerunning the job, it will upload the artifacts 😟

@jneira
Copy link
Member Author

jneira commented Nov 11, 2020

@bubba i've deleted the tag and release and include your last fixes, let's see what happens now

@jneira
Copy link
Member Author

jneira commented Nov 11, 2020

@bubba it is unfortunate that the tag and release had to be deleted to trigger a clean github action.
I thought we could at least delete only uploaded artifacts and rerun the build but the tar job cant be rerunned (??)

@jneira jneira deleted the prepare-0.6 branch December 3, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukel97 lukel97 lukel97 approved these changes

@isovector isovector isovector approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@alanz alanz Awaiting requested review from alanz

@wz1000 wz1000 Awaiting requested review from wz1000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2020-11 monthly release
3 participants
@jneira @lukel97 @isovector