-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow GHC 9.12 #449
fix: allow GHC 9.12 #449
Conversation
ncaq
commented
Jan 16, 2025
- fix: allow GHC 9.12
- ci: add GHC 9.12 version in CI matrix
Thanks for the PR! Would you mind fixing the |
I wonder if the new cabal is newer and has new warnings? I have sent a PR to the other party about the issue of Windows builds mocking up due to lack of consideration of unix-compat. |
I think the haskell/setup action just bumped the cabal version, iirc, we are not pinning the exact cabal or gh action version.
Depends on what you need, if you just want to update |
Then, I guess we should still think about this PR after we know that the following PRs will be merged or left out. |
The PR to unix-compat has been merged and I will wait for it to be release to Hackage. |
@ncaq I think this should only need a rebase, right? |
allow GHC 9.12 builtin library version. ci: add GHC 9.12 version in CI matrix === build: head location protocol from git to https === Address the following warning. ``` The following errors are likely to affect your build negatively: Error: [git-protocol] Cloning over git:// might lead to an arbitrary code execution vulnerability. Furthermore, popular forges like GitHub do not support it. Use https:// or ssh:// instead. Error: Hackage would reject this package. ```
Would you have preferred it to be combined into one? |
@ncaq Sorry, I don't quite understand the question? One commit, one PR? I think the PR as is looks good to me. |
Sorry, I am not good at English and I am writing this in machine translation, so I may not have grasped your intention properly. |
Ah, yes, don't worry that's fine :) You did exactly what I asked for, thank you very much! I intend to merge this PR as soon as CI is finished. |
I amended the version dependencies on hackage, https://hackage.haskell.org/package/hie-bios-0.14.0, I can build now |