Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow GHC 9.12 #449

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: allow GHC 9.12 #449

merged 1 commit into from
Feb 10, 2025

Conversation

ncaq
Copy link
Contributor

@ncaq ncaq commented Jan 16, 2025

  • fix: allow GHC 9.12
  • ci: add GHC 9.12 version in CI matrix

@fendor
Copy link
Collaborator

fendor commented Jan 16, 2025

Thanks for the PR! Would you mind fixing the cabal check issue as well?

@ncaq
Copy link
Contributor Author

ncaq commented Jan 16, 2025

I wonder if the new cabal is newer and has new warnings?
I'm sure I didn't play around with this area this time.
I rewrote the git protocol to https and probably took care of it.

I have sent a PR to the other party about the issue of Windows builds mocking up due to lack of consideration of unix-compat.
There are several ways to deal with the unix-compat issue, such as referencing my fork in cabal.project, disabling strict dependency checking only in 9.12, or waiting for the other party to publish unix-compat.
How should I handle this?

@fendor
Copy link
Collaborator

fendor commented Jan 16, 2025

I think the haskell/setup action just bumped the cabal version, iirc, we are not pinning the exact cabal or gh action version.

How should I handle this?

Depends on what you need, if you just want to update hie-bios for the sake of it, I'd wait since we can't upload the changes to hackage any way. If you depend on these changes in any other way, I'd be fine with adding your fork in cabal.project and then we can remove the fork again once we actually want to upload to hackage.

@ncaq
Copy link
Contributor Author

ncaq commented Jan 16, 2025

Then, I guess we should still think about this PR after we know that the following PRs will be merged or left out.
I don't plan to use hie-bios on native non-WSL Windows for a while, so I'm not really bothered.
fix: allow time-1.14 by ncaq · Pull Request #15 · haskell-pkg-janitors/unix-compat

@ncaq
Copy link
Contributor Author

ncaq commented Jan 20, 2025

The PR to unix-compat has been merged and I will wait for it to be release to Hackage.
fix: allow time-1.14 by ncaq · Pull Request #15 · haskell-pkg-janitors/unix-compat

@fendor
Copy link
Collaborator

fendor commented Feb 9, 2025

@ncaq I think this should only need a rebase, right?

allow GHC 9.12 builtin library version.

ci: add GHC 9.12 version in CI matrix
===

build: head location protocol from git to https
===

Address the following warning.

```
The following errors are likely to affect your build negatively:
Error: [git-protocol] Cloning over git:// might lead to an arbitrary code
execution vulnerability. Furthermore, popular forges like GitHub do not
support it. Use https:// or ssh:// instead.
Error: Hackage would reject this package.
```
@ncaq
Copy link
Contributor Author

ncaq commented Feb 10, 2025

Would you have preferred it to be combined into one?
I rebased it.

@fendor
Copy link
Collaborator

fendor commented Feb 10, 2025

@ncaq Sorry, I don't quite understand the question? One commit, one PR? I think the PR as is looks good to me.

@ncaq
Copy link
Contributor Author

ncaq commented Feb 10, 2025

Sorry, I am not good at English and I am writing this in machine translation, so I may not have grasped your intention properly.
First I will follow your instructions.
I rebased as I thought you said you wanted me to rebase.
I am willing to do whatever it takes to get this PR imported.
Do you want to leave it as it is at this now?
Or do you want to revert what you rebased since the reflog is still on my computer?

@fendor
Copy link
Collaborator

fendor commented Feb 10, 2025

Ah, yes, don't worry that's fine :)

You did exactly what I asked for, thank you very much! I intend to merge this PR as soon as CI is finished.
I don't think there is anything else you need to do :) I am happy with the current PR state.

@fendor fendor merged commit b750c11 into haskell:master Feb 10, 2025
22 checks passed
@fendor
Copy link
Collaborator

fendor commented Feb 10, 2025

I amended the version dependencies on hackage, https://hackage.haskell.org/package/hie-bios-0.14.0, I can build now hie-bios-0.14.0 with ghc-9.12.1 :) Thanks for your contribution!

@ncaq ncaq deleted the allow-ghc-9.12 branch February 10, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants