Fix haddock for negativeBinomial, remove references to original bos repo #217
Conversation
| @@ -166,14 +166,14 @@ directEntropy d = | |||
| dropWhile (>= -m_epsilon) $ | |||
| [ let x = probability d k in x * log x | k <- [0..]] | |||
|
|
|||
| -- | Construct negative binomial distribution. Number of failures /r/ | |||
| -- | Construct negative binomial distribution. Number of successes /r/ | |||
There was a problem hiding this comment.
This got me really confused because it's in conflict with the -- ^ Number of successes. on the lines below.
This is even more confusing, because the "output" of the distribution is probability of number of failures before we get r-th success.
But here, r is the (input) parameter of the distribution representing the number of successes that need to occur overall.
| @@ -151,7 +151,7 @@ complCumulative (NBD r p) x | |||
| | k < 0 = 1 | |||
| | otherwise = incompleteBeta (fromIntegral (k+1)) r (1 - p) | |||
| where | |||
| k = (floor x)::Integer | |||
| k = floor x :: Integer | |||
There was a problem hiding this comment.
Just an hlint warning fix here. Note that k = floor x :: Integer is already used on line 145 above, so this makes the code a bit more consistent.
jhrcek
changed the title
|
|
||
| * `git clone git://github.com/bos/statistics.git` | ||
|
|
||
| There's also a [Mercurial mirror](https://bitbucket.org/bos/statistics): |
There was a problem hiding this comment.
This gives me 404 repository not found
| @@ -36,14 +36,16 @@ category: Math, Statistics | |||
|
|
|||
| extra-source-files: | |||
| README.markdown | |||
| changelog.md | |||
There was a problem hiding this comment.
Fixing cabal check warning:
Warning: [doc-place] Please consider moving the file 'changelog.md' from the
'extra-source-files' section of the .cabal file to the section
'extra-doc-files'.
|
Hello @Shimuuar |
|
Thank you, for all boring cleanup work and documentation fixes! PR looks good sorry for the wait |
No description provided.