Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare pre-release 2.5.0 #940

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Aug 17, 2023

Pre-release 2.5.0

We are excited to announce the pre-release of a new feature that will greatly enhance the experience with HLS! With this release, we have added comprehensive support for .cabal files at the IDE level. This includes advanced features such as file formatting, diagnostics, and auto completions.

One of our talented developers, @VeryMilkyJoe, has worked tirelessly on implementing this feature throughout the summer. We are grateful for this hard work and dedication. Now, we are thrilled to share this exciting update with all of you.

To ensure seamless integration, it is important to note that this functionality requires HLS version 1.8.0.0 or higher. Failure to meet this requirement may result in .cabal files being treated as Haskell files. We are aware that there are currently some unrelated error logs present. However, we kindly request our users to ignore these logs for .cabal files as we continue to work diligently towards resolving them.

Please refer to @VeryMilkyJoe's summary for demonstrations, which can be found here.

Thank you for your continued support!

Changes

@July541 July541 requested review from VeryMilkyJoe and fendor August 17, 2023 15:58
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much!

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we are missing one thing

@fendor
Copy link
Collaborator

fendor commented Aug 17, 2023

We need to add

    "haskell.plugin.cabal.completionOn": {
        "default": true,
        "description": "Enables cabal completions",
        "scope": "resource",
        "type": "boolean"
    },

to package.json.

In general, in a release, we ought to run haskell-language-server vscode-extension-schema and copy-paste the output into package.json.

However, it is a bit tricky because sometimes, a GHC version you compiled HLS with doesn't have all the plugins available, the output is then incomplete. We have no readily available solution for this issue yet. Related issue: haskell/haskell-language-server#3660

@July541
Copy link
Collaborator Author

July541 commented Aug 17, 2023

Is there anything else about formatter we need to update?

@fendor
Copy link
Collaborator

fendor commented Aug 17, 2023

I don't think so.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the documentation

@July541 July541 merged commit 4a262a5 into haskell:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants