-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching plugin docs #772
base: main
Are you sure you want to change the base?
Caching plugin docs #772
Conversation
Error testing the assertions. Check the logs. |
Redirects 🔀Hey, @robertjdominguez & @seanparkross — the following redirects will be needed for deployment:
|
@i-am-tom Thanks for your PR! I've assigned @robertjdominguez to review it. |
Deploying v3-docs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is a great addition @i-am-tom 🎉
I made a few suggestions for ordering clarity. One important thing: it was quite clear in @paritosh-08's example for allowlists how this should eventually be deployed. While the docker setup is great for local dev, can we add a section at the end that explains how users should handle referencing the deployed version of this plugin?
From my understanding, we don't host plugins. So, maybe taking the url
value for the plugin and throwing it into an env would be a good start? Then, simply explain that in their .env.cloud
they'd modify that value to reflect the deployed instance?
Co-authored-by: Rob Dominguez <[email protected]>
Co-authored-by: Rob Dominguez <[email protected]>
Co-authored-by: Rob Dominguez <[email protected]>
Description 📝
This PR adds a quickstart guide for the caching plugin. It also renames the current quickstart guide for plugins to be allowlist-specific.
Quick Links 🚀
Assertion Tests 🤖
The documentation now describes how to add server-side caching to an existing Hasura project.