Enable readability-redundant-string-init

Enable this clang-tidy check and fix existing warnings related to it.
haukeschuemann · Aug 4, 2019 · 8080527 · 8080527
1 parent becab72
commit 8080527
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -73,7 +73,6 @@ readability-*,\
 -readability-redundant-control-flow,\
 -readability-redundant-declaration,\
 -readability-redundant-preprocessor,\
--readability-redundant-string-init,\
 "
 WarningsAsErrors: '*'
 HeaderFilterRegex: '(src|test).*'

diff --git a/src/character.cpp b/src/character.cpp
@@ -3500,7 +3500,7 @@ int Character::get_shout_volume() const
 void Character::shout( std::string msg, bool order )
 {
     int base = 10;
-    std::string shout = "";
+    std::string shout;
 
     // You can't shout without your face
     if( has_trait( trait_PROF_FOODP ) && !( is_wearing( itype_id( "foodperson_mask" ) ) ||

diff --git a/src/magic.cpp b/src/magic.cpp
@@ -1393,7 +1393,7 @@ void spellcasting_callback::draw_spell_info( const spell &sp, const uilist *menu
 
     line++;
 
-    std::string targets = "";
+    std::string targets;
     if( sp.is_valid_target( target_none ) ) {
         targets = "self";
     } else {
@@ -1420,7 +1420,7 @@ void spellcasting_callback::draw_spell_info( const spell &sp, const uilist *menu
         }
         if( sp.aoe() > 0 ) {
             std::string aoe_string_temp = "Spell Radius";
-            std::string degree_string = "";
+            std::string degree_string;
             if( fx == "cone_attack" ) {
                 aoe_string_temp = "Cone Arc";
                 degree_string = "degrees";

diff --git a/src/ranged.cpp b/src/ranged.cpp
@@ -1376,7 +1376,7 @@ std::vector<tripoint> target_handler::target_ui( player &pc, target_mode mode,
             }
             if( mode == TARGET_MODE_FIRE || mode == TARGET_MODE_TURRET_MANUAL ) {
                 auto m = relevant->gun_current_mode();
-                std::string str = "";
+                std::string str;
                 nc_color col = c_light_gray;
                 if( relevant != m.target ) {
                     str = string_format( _( "Firing mode: <color_cyan>%s %s (%d)</color>" ),