fix(permutation): filter permutations by valid tld #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During `Domain` initialization we are validating whether or not the fqdn passed is a valid domain. Prior to this patch it would also accept structurally valid domains, which have invalid tlds (e.g., ęxamplę.čom). This patch adds a bst search on the `TLDS` constant that we build at compile-time to check that it's a valid tld as well.
Not really pretty but the current `TLDS` only focuses on root-level tlds (e.g., `.uk` but not `.ac.uk`). * Add an `EXTENDED_TLDS` const which includes all variants of these TLDs. This is then applied to the filtering when creating Domains; * Move `TLDS` creation from build-time to a const slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
Domaininitialization we are validating whether or not the fqdn passed is a valid domain. Prior to this patch it would also accept structurally valid domains, which have invalid tlds (e.g., ęxamplę.čom).This patch adds a bst search on the
TLDSconstant that we build at compile-time to check that it's a valid tld as well.