Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-564_IMDG_Banner #197

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

rebekah-lawrence
Copy link
Contributor

Updated text and link colours. Rebuilt uibundle.

Updated text and link colours. Rebuilt uibundle.
@Serdaro
Copy link
Contributor

Serdaro commented Nov 28, 2023

@Serdaro
Copy link
Contributor

Serdaro commented Nov 28, 2023

And the changes in question should be included in the relevant source files of this repo, that is, the updated files also need to be pushed.

@rebekah-lawrence
Copy link
Contributor Author

Thanks @Serdaro a few questions before I do it:

  • looking at the releases, I have to provide a .zip and a .tar.gz version of the source files?
  • this PR can just be closed, to be replaced by the Release?
  • In the Release, I leave Set as the latest release selected?
  • there's no check, I just upload the files to a release and publish?

@Serdaro
Copy link
Contributor

Serdaro commented Nov 28, 2023

Thanks @Serdaro a few questions before I do it:

  • looking at the releases, I have to provide a .zip and a .tar.gz version of the source files?
  • this PR can just be closed, to be replaced by the Release?
  • In the Release, I leave Set as the latest release selected?
  • there's no check, I just upload the files to a release and publish?
  • No, zip and tar.gz are created automatically when you make a new release. You just need to attach the ui-bundle.zip to the release. When releasing, it is a convenience to provide the changes in the release description.
  • Yes, but there should be a PR in which the relevant files are updated. You don't need to upload the ui-bundle.zip.
  • Yes
  • Yes

Following Serdar's comments, I have removed the uibundle.zip from the PR and instead added the updaed file (main.hbs)
Following Serdar's comments, I have removed the updated uibundle from this PR and included only the updated file (main.hbs)
@rebekah-lawrence rebekah-lawrence merged commit f4e223c into master Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants