-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-12: new homepage design #206
DOC-12: new homepage design #206
Conversation
Overall it's looking good and great to be able to pull this branch down and build versions of this ourselves! Some quick feedback comments here, based on the original design but also pulling in some comments from recent discussions / iterations:
|
Looks awesome @fantkolja. Not sure if this is the time to comment on the article pages (not the landing page), but just wanted to share. Here are some cute minor issues:
And here are comments for you, @rebekah-lawrence and @oliverhowell:
|
@oliverhowell @Serdaro I have fixed all the issues in your comments, except for the "Right Navigation Menu" issue from @Serdaro's comment. My thoughts:
|
Adding screenshots for the right-hand menu issue - the issue is the Edit/Rate page section is part of the right-hand menu so for extra long pages you don't see it unless you scroll right down to the end (yet there is plenty of space to show it if these buttons were in a different div): It does seem to be an issue with existing site too so not a regression. |
Happy to add this to a new issue but could we add a tag onto the Get Hazelcast button in the top right? |
I've got a local build with this enabled for both the hazelcast.com links in header: |
Spotted in a local build, but can be seen in https://docs.hazelcast.com/hazelcast/5.5-snapshot/system-properties: Where a Note is in a table ( |
…om/fantkolja/hazelcast-docs-ui into feature/doc-12-new-homepage-design
…olja/hazelcast-docs-ui into feature/doc-12-new-homepage-design
Getting ready to make this live - some minor issues/questions @fantkolja : |
No description provided.