-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-280: add padding for images #243
Conversation
src/css/expanded-image.css
Outdated
@@ -4,6 +4,7 @@ | |||
border-radius: 5px; | |||
cursor: pointer; | |||
transition: 0.3s; | |||
padding: 20px 20px 20px 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work because it's an inline element.
You should probably also add
display: inline-block
or display: block
And also I would add only top and bottom padding. (padding: 20px 0
), unless you want to achieve something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe my suggestion is not ideal or goes too wide...I floated an image in the What's New and this has the wrapping issue:
https://deploy-preview-1393--hardcore-allen-f5257d.netlify.app/hazelcast/6.0-snapshot/ask-ai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though it does seem to fix the particular issue which is what I was looking for...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I see :)
Then it does work indeed. Previously I was checking a non-floating image and it had no effect on it.
src/css/expanded-image.css
Outdated
@@ -4,6 +4,7 @@ | |||
border-radius: 5px; | |||
cursor: pointer; | |||
transition: 0.3s; | |||
padding: 20px 20px 20px 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding: 20px 20px 20px 20px; | |
padding: 20px; |
With the slack conversation you think this change is ok then @fantkolja ? |
Suggestions added from slack discussion |
No description provided.