Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viridian -> Cloud #340

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

rebekah-lawrence
Copy link
Contributor

Description of change

Changes to top-level playbooks, addition of playbooks for 5.4, and other changes on this repo to README and search-config to support the change of name from Viridian to Cloud

Type of change

Select the type of change that you're making:

  • Bug fix (Addresses an issue in existing content such as a typo)
  • Enhancement (Adds new content)
  • rename of Viridian to cloud

Open Questions and Pre-Merge TODOs

  • Use github checklists to create a list. When an item is solved, check the box and explain the answer.

Changes to top-level playbooks, addition of playbooks for 5.4, and other changes on this repo to README and search-config to support the change of name from Viridian to Cloud
Copy link
Collaborator

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (conflict resolution aside)

Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor fixes.
(let the 53-pdf for now stay as it is, as there is no 54-pdf branch on my profile).

@@ -35,7 +35,7 @@ content:
- url: https://github.com/hazelcast-guides/airline-connections
branches: main
start_path: docs
- url: https://github.com/hazelcast-guides/sql_basics_on_viridian
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud
- url: https://github.com/hazelcast-guides/sql_stock_ticker_cloud

@@ -41,7 +41,7 @@ content:
- url: https://github.com/hazelcast-guides/Generating-Data-using-SQL
branches: master
start_path: docs
- url: https://github.com/hazelcast-guides/sql_basics_on_viridian
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud
- url: https://github.com/hazelcast-guides/sql_stock_ticker_cloud

content:
sources:
- url: https://github.com/serdaro/hz-docs
branches: [54-pdf]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: [54-pdf]
branches: [53-pdf]

Serdaro and others added 3 commits February 27, 2024 13:16
@rebekah-lawrence rebekah-lawrence merged commit 7464b3c into develop Feb 27, 2024
4 of 6 checks passed
@rebekah-lawrence rebekah-lawrence deleted the DOCS-762_Rename_Viridian_Variables branch February 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants