-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viridian -> Cloud #340
Viridian -> Cloud #340
Conversation
Changes to top-level playbooks, addition of playbooks for 5.4, and other changes on this repo to README and search-config to support the change of name from Viridian to Cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (conflict resolution aside)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor fixes.
(let the 53-pdf for now stay as it is, as there is no 54-pdf branch on my profile).
antora-playbook-local.yml
Outdated
@@ -35,7 +35,7 @@ content: | |||
- url: https://github.com/hazelcast-guides/airline-connections | |||
branches: main | |||
start_path: docs | |||
- url: https://github.com/hazelcast-guides/sql_basics_on_viridian | |||
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud | |
- url: https://github.com/hazelcast-guides/sql_stock_ticker_cloud |
antora-playbook.yml
Outdated
@@ -41,7 +41,7 @@ content: | |||
- url: https://github.com/hazelcast-guides/Generating-Data-using-SQL | |||
branches: master | |||
start_path: docs | |||
- url: https://github.com/hazelcast-guides/sql_basics_on_viridian | |||
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- url: https://github.com/hazelcast-guides/sql_basics_on_cloud | |
- url: https://github.com/hazelcast-guides/sql_stock_ticker_cloud |
assembler-playbook-platform-5-4.yml
Outdated
content: | ||
sources: | ||
- url: https://github.com/serdaro/hz-docs | ||
branches: [54-pdf] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches: [54-pdf] | |
branches: [53-pdf] |
Should already be in PR from Serdar's updates, but just to be sure to be sure
…om/hazelcast/hazelcast-docs into DOCS-762_Rename_Viridian_Variables
Description of change
Changes to top-level playbooks, addition of playbooks for 5.4, and other changes on this repo to README and search-config to support the change of name from Viridian to Cloud
Type of change
Select the type of change that you're making:
Open Questions and Pre-Merge TODOs