Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commit hash (not tag) for EnricoMi/publish-unit-test-result-action version specification #530

Conversation

JackPGreen
Copy link
Contributor

Currently we are referencing a tag when specifying the version of the EnricoMi/publish-unit-test-result-action, which is potentially mutable.

It was requested that the commit SHA be used instead, as per the GitHub actions security hardening guide.

Updated the version specification to the commit hash of the currently used version - i.e. no changes to the actual version of the action being used.

…on` version specification


Currently we are referencing a tag when specifying the version of the `EnricoMi/publish-unit-test-result-action`, which is potentially mutable.

[It was requested](https://github.com/hazelcast/hazelcast-mono/pull/2422/files/e0b1647cd0e713602c2fe215bf253510637d8037#r1727207988) that the commit SHA be used instead, as per the [GitHub actions security hardening guide](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions).

Updated the version specification to the commit hash of the [currently used version](https://github.com/EnricoMi/publish-unit-test-result-action/releases/tag/v2.17.0) - i.e. no changes to the actual version of the action being used.
@JackPGreen JackPGreen requested a review from kwart August 22, 2024 15:49
@JackPGreen JackPGreen self-assigned this Aug 22, 2024
@JackPGreen JackPGreen requested a review from a team as a code owner August 22, 2024 15:49
Copy link

Test Results

128 tests  ±0   128 ✅ ±0   57s ⏱️ -2s
 24 suites ±0     0 💤 ±0 
 24 files   ±0     0 ❌ ±0 

Results for commit ca8be5d. ± Comparison against base commit ff05c7e.

@JackPGreen JackPGreen enabled auto-merge (squash) August 22, 2024 16:07
@JackPGreen JackPGreen merged commit 8c427c3 into hazelcast:master Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants