Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for LDAP security provider [CN-995] #139

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Conversation

SeriyBg
Copy link
Contributor

@SeriyBg SeriyBg commented Oct 11, 2023

No description provided.

@SeriyBg SeriyBg requested review from cagric0 and semihbkgr October 11, 2023 08:13
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for pedantic-goldberg-f76ec1 ready!

Name Link
🔨 Latest commit 6da01fd
🔍 Latest deploy log https://app.netlify.com/sites/pedantic-goldberg-f76ec1/deploys/6529499744a41b000813044e
😎 Deploy Preview https://deploy-preview-139--pedantic-goldberg-f76ec1.netlify.app/operator/latest-snapshot/management-center-ldap
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SeriyBg SeriyBg added this to the 5.10 milestone Oct 11, 2023
licenseKeySecretName: hazelcast-license-key
securityProvider:
ldap:
credentialsSecretName: ldap-credentianls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add sample credentials yaml or command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SeriyBg SeriyBg requested a review from hasancelik October 11, 2023 11:00

|`credentialsSecretName`
| The name of the secret that contains `username` and `password` keys of a user that has admin privileges on the LDAP server. The `username` must be the DN of the user. It is used to connect to the server when authenticating users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to show the expanded word for DN when it is used for the first time. Something like:

"... must be the distinguished name (DN) of the user. ..."

@SeriyBg SeriyBg requested a review from Serdaro October 13, 2023 13:43
@SeriyBg SeriyBg merged commit 5bcc399 into main Oct 18, 2023
@SeriyBg SeriyBg deleted the CN-995-mc-ldap branch October 18, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants