Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-437 #141

Merged
merged 3 commits into from
Feb 14, 2024
Merged

DOCS-437 #141

merged 3 commits into from
Feb 14, 2024

Conversation

rebekah-lawrence
Copy link
Contributor

Rewrote the Overview to explain that Platform Operator documentation is aimed at dev/devops with intermediate K8 knowledge.

Rewrote the Overview to explain that Operator is aimed at dev/devops with intermediate K8 knowledge
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for pedantic-goldberg-f76ec1 ready!

Name Link
🔨 Latest commit 95a6c5c
🔍 Latest deploy log https://app.netlify.com/sites/pedantic-goldberg-f76ec1/deploys/65cb5ccf651365000862596f
😎 Deploy Preview https://deploy-preview-141--pedantic-goldberg-f76ec1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hasancelik hasancelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @rebekah-lawrence

Could you update support section also with required information?
https://docs.hazelcast.com/hazelcast/latest/getting-started/support#community-support


{description}

Hazelcast Platform Operator allows your development and DevOps teams to automate common management tasks for your Hazelcast clusters on Kubernetes and Red Hat OpenShift. For example, you can use Hazelcast Platform Operator to automate the following tasks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Hazelcast Platform Operator allows your development and DevOps teams to automate common management tasks for your Hazelcast clusters on Kubernetes and Red Hat OpenShift. For example, you can use Hazelcast Platform Operator to automate the following tasks:
Hazelcast Platform Operator allows your development and DevOps teams to automate common management tasks for your Hazelcast clusters on Kubernetes and Red Hat OpenShift. For example, you can use Hazelcast Platform Operator to automate the following tasks:

Removed extra space and added information on Community support
Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasancelik hasancelik self-requested a review November 24, 2023 08:43

{description}

Hazelcast Platform Operator allows your development and DevOps teams to automate common management tasks for your Hazelcast clusters on Kubernetes and Red Hat OpenShift. For example, you can use Hazelcast Platform Operator to automate the following tasks:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebekah-lawrence , the last couple of words of the description text and the sentence after it are the same. The flow or reading made me feel a duplication since they are very close to each other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, here was my logic:

  • The first sentence was already too long (24 words), so I didn't want to add something like ", such as the following"
  • They are a duplication as one is introducing examples of the other; it is difficult to avoid the duplication and retain the sense of what is being introduced
  • People scan, so the duplication also helps to ensure they do digest what is being said. Also, I'd rather use the same words than paraphrase for variety so that people don't have to think while they scan

Any suggestions to improve it?

* https://github.com/hazelcast/hazelcast[Hazelcast GitHub^] (for reporting issues through our GitHub repository)
* https://slack.hazelcast.com/[Hazelcast Community Slack^]
* https://groups.google.com/forum/#!forum/hazelcast[Mail Group^]
* http://www.stackoverflow.com/[StackOverflow^]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a customer support section here as well?

https://docs.hazelcast.com/hazelcast/5.3/getting-started/support#customer-support

For support, find us in the https://slack.hazelcast.com/[Hazelcast Community Slack^].
Community support is for every Hazelcast user. You can use the following channels to get community support:

* https://github.com/hazelcast/hazelcast[Hazelcast GitHub^] (for reporting issues through our GitHub repository)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* https://github.com/hazelcast/hazelcast[Hazelcast GitHub^] (for reporting issues through our GitHub repository)
* https://github.com/hazelcast/hazelcast-platform-operator[Platform Operator GitHub^] (for reporting issues through our GitHub repository)

Comment on lines 31 to 32
* https://groups.google.com/forum/#!forum/hazelcast[Mail Group^]
* http://www.stackoverflow.com/[StackOverflow^]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these two, because they are not very active 🙂

Suggested change
* https://groups.google.com/forum/#!forum/hazelcast[Mail Group^]
* http://www.stackoverflow.com/[StackOverflow^]

Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@rebekah-lawrence rebekah-lawrence merged commit 18b8222 into main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants