[CN-1048, CN-1047] Add missing field descriptions #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pedantic-goldberg-f76ec1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
degerhz
changed the title
SeriyBg
approved these changes
Nov 1, 2023
| @@ -41,6 +44,9 @@ The following are the required fields to configure the LDAP Security provider. | |||
| |`groupSearchFilter` | |||
| | LDAP search filter expression to search for the groups. | |||
|
|
|||
| |`nestedGroupSearch` | |||
There was a problem hiding this comment.
This one is not required, as mentioned in the section above, that's why I didn't document it here. All the fields with the optional ones are included in the Refrence API doc page 😃
There was a problem hiding this comment.
Hmm I didn't know that, I'll remove it back. How about URL field? It was missing or it's also intentionally removed
There was a problem hiding this comment.
URL is required, so it was just missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.