[CN-1372]: add note to TLS document about how to update TLS #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pedantic-goldberg-f76ec1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hasancelik
approved these changes
Oct 16, 2024
oliverhowell
requested changes
Oct 16, 2024
docs/modules/ROOT/pages/tls.adoc
Outdated
| @@ -74,3 +74,5 @@ include::ROOT:example$/hazelcast-tls.yaml[] | |||
| ---- | |||
| include::ROOT:example$/management-center-tls.yaml[] | |||
| ---- | |||
|
|
|||
| NOTE: To update TLS certificates, it is required to delete and recreate the Hazelcast/Management Center custom resource. | |||
There was a problem hiding this comment.
Suggested change
| NOTE: To update TLS certificates, it is required to delete and recreate the Hazelcast/Management Center custom resource. | |
| NOTE: To update TLS certificates, you need to delete and recreate the appropriate custom resource in Hazelcast Platform or Management Center. |
Is it either the Hazelcast or MC resource you need to delete or both? The / is ambiguous here...
There was a problem hiding this comment.
TLS certificates are applicable for both CRs. So whichever you created you should delete it and recreate.
There was a problem hiding this comment.
What do you think of update suggestion then?
There was a problem hiding this comment.
I think this should be enough: NOTE: To update TLS certificates, you need to delete and recreate the appropriate custom resource, WDYT?
oliverhowell
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.