Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-1421]: introduce client simple authentication doc #260

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kutluhanmetin
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for pedantic-goldberg-f76ec1 ready!

Name Link
🔨 Latest commit 6094579
🔍 Latest deploy log https://app.netlify.com/sites/pedantic-goldberg-f76ec1/deploys/674ff44c3ff716000861bd34
😎 Deploy Preview https://deploy-preview-260--pedantic-goldberg-f76ec1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@amandalindsay amandalindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak, and a question about another. Otherwise, looks good

docs/modules/ROOT/pages/client-auth.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/client-auth.adoc Outdated Show resolved Hide resolved
@kutluhanmetin kutluhanmetin requested review from amandalindsay and removed request for oliverhowell November 7, 2024 06:24
@kutluhanmetin kutluhanmetin changed the title [CN-1421]: introduce client authentication doc [CN-1421]: introduce client simple authentication doc Nov 28, 2024
Copy link
Contributor

@hasancelik hasancelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom Config should require some changes also:
https://docs.hazelcast.com/operator/latest-snapshot/custom-config

  1. Security is not configurable over custom config anymore so we should mention at https://docs.hazelcast.com/operator/latest-snapshot/custom-config#security-configuration
  2. Security-based sample YAMLs also should be removed or changed with another one.

@kutluhanmetin
Copy link
Contributor Author

Custom Config should require some changes also: https://docs.hazelcast.com/operator/latest-snapshot/custom-config

  1. Security is not configurable over custom config anymore so we should mention at https://docs.hazelcast.com/operator/latest-snapshot/custom-config#security-configuration
  2. Security-based sample YAMLs also should be removed or changed with another one.

@hasancelik I addressed this in the commit: 6bef71a. Would you re-review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants