Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs #3

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix bugs #3

merged 2 commits into from
Nov 14, 2024

Conversation

oberonia78
Copy link

Fix bugs in PR (opera-adt#112)

@@ -249,7 +249,7 @@ def get_freq_rtc_hdf5(input_rtc):
with h5py.File(input_rtc) as src_h5:
freq_group_list = src_h5[path_freq][()]
freq = [freq_group.decode('utf-8') for freq_group in freq_group_list]

freq = ['A']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oberonia78 , I am not sure why freq is hardcoded here? Could you let me know your thoughts?

@@ -379,7 +379,7 @@ def read_rtc_resolution(input_h5_list, freq_list):

# Flatten the array and filter out None values
res_list_valid = [item for item in res_list.flatten() if item is not None]
res_highest = max(res_list_valid)
res_highest = min(res_list_valid)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about it. You are right

@@ -593,7 +593,7 @@ def check_polarizations(pol_list, input_dir_list, DSWX_NI_POL_DICT):

# Find polarization of files in list of directories
found_pol = _find_polarization_from_data_dirs(input_dir_list)

print(found_pol, 'found')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to remove it?

Copy link
Owner

@hb6688 hb6688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. You are removing the print statements here.

@hb6688 hb6688 merged commit 592adf6 into hb6688:dswx-ni-beta-point Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants