Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skohub PubSub post #66

Merged
merged 16 commits into from
Jun 25, 2020
Merged

Skohub PubSub post #66

merged 16 commits into from
Jun 25, 2020

Conversation

acka47
Copy link
Contributor

@acka47 acka47 commented Jun 19, 2020

No description provided.

@acka47 acka47 marked this pull request as draft June 19, 2020 13:01
@acka47
Copy link
Contributor Author

acka47 commented Jun 19, 2020

For finishing this post, skohub-io/skohub-pubsub#36 (and at best also skohub-io/skohub-vocabs#87) should befixed at first.

Also, @literarymachine, it would be nice if you could look over this and add a paragraph on implementation (similar to http://blog.lobid.org/2020/03/31/skohub-editor.html#implementation).

I would be happy to publish this next Wednesday or latest on Thursday.

@acka47
Copy link
Contributor Author

acka47 commented Jun 24, 2020

@literarymachine I updated a few things, also one in the outlook. Please take a look whether it's fine with you and I will publish the post tomorrow morning.

@acka47 acka47 marked this pull request as ready for review June 24, 2020 14:11
@acka47 acka47 requested review from literarymachine and fsteeg June 24, 2020 14:11
Copy link
Contributor

@literarymachine literarymachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@literarymachine literarymachine removed their assignment Jun 24, 2020
@acka47 acka47 requested a review from dr0i June 25, 2020 06:35
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated a screenshot.
Besides that, a very well written post considering the complexity of the topic :)

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some minor tweaks and fixes. Nice post!

@acka47 acka47 merged commit d7eec52 into master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants