fix(ngModelOptions): allow sharing options between multiple inputs

Closes angular#10667
hd19861028 · Jan 8, 2015 · 9c9c6b3 · 9c9c6b3
1 parent 51d6774
commit 9c9c6b3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/ng/directive/ngModel.js b/src/ng/directive/ngModel.js
@@ -1215,7 +1215,7 @@ var ngModelOptionsDirective = function() {
     restrict: 'A',
     controller: ['$scope', '$attrs', function($scope, $attrs) {
       var that = this;
-      this.$options = $scope.$eval($attrs.ngModelOptions);
+      this.$options = angular.copy($scope.$eval($attrs.ngModelOptions));
       // Allow adding/overriding bound events
       if (this.$options.updateOn !== undefined) {
         this.$options.updateOnDefault = false;

diff --git a/test/ng/directive/ngModelSpec.js b/test/ng/directive/ngModelSpec.js
@@ -1733,6 +1733,34 @@ describe('ngModelOptions attributes', function() {
   });
 
 
+  it('should allow sharing options between multiple inputs', function() {
+    $rootScope.options = {updateOn: 'default'};
+    var inputElm = helper.compileInput(
+        '<input type="text" ng-model="name1" name="alias1" ' +
+          'ng-model-options="options"' +
+        '/>' +
+        '<input type="text" ng-model="name2" name="alias2" ' +
+          'ng-model-options="options"' +
+        '/>');
+
+    helper.changeGivenInputTo(inputElm.eq(0), 'a');
+    helper.changeGivenInputTo(inputElm.eq(1), 'b');
+    expect($rootScope.name1).toEqual('a');
+    expect($rootScope.name2).toEqual('b');
+  });
+
+
+  it('should hold a copy of the options object', function() {
+    $rootScope.options = {updateOn: 'default'};
+    var inputElm = helper.compileInput(
+        '<input type="text" ng-model="name" name="alias" ' +
+          'ng-model-options="options"' +
+        '/>');
+    expect($rootScope.options).toEqual({updateOn: 'default'});
+    expect($rootScope.form.alias.$options).not.toBe($rootScope.options);
+  });
+
+
   it('should allow overriding the model update trigger event on checkboxes', function() {
     var inputElm = helper.compileInput(
         '<input type="checkbox" ng-model="checkbox" ' +