Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing comma; add patsy requirements from requirements.txt #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

missing comma; add patsy requirements from requirements.txt #112

wants to merge 1 commit into from

Conversation

harrisonritz
Copy link

  1. setup.py install fails because of missing comma
  2. patsy didn't have requirements, so matched to requirements.txt. if this was blank for a good reason, then feel free to ignore.

Can't test PR because can't install hddm.

@AlexanderFengler AlexanderFengler self-requested a review February 23, 2024 02:31
AlexanderFengler
AlexanderFengler approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
The comma was a bug, patsy will install to 0.5... something either way, but no issue with making version specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderFengler AlexanderFengler AlexanderFengler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrisonritz @AlexanderFengler