Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export pdk/build_defs.bzl so that StandardCellInfo can be used (and tested) by XLS #200

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

tcal-x
Copy link
Member

@tcal-x tcal-x commented Sep 28, 2023

Not sure if I need to export open_road_configuration as well, or just the entry point? The goal is to access do_not_use_cell_list. This is the only export I need internally.

@tcal-x tcal-x requested a review from QuantamHD September 28, 2023 07:08
@QuantamHD
Copy link
Collaborator

Bzl files don't require an export to use them in other bzl files

@tcal-x
Copy link
Member Author

tcal-x commented Sep 28, 2023

Bzl files don't require an export to use them in other bzl files

There is a meta-Bazel test //xls/build_rules:xls_rules_bzl_parse_file_test that does need this export.

This is the failure from XLS bazel testing (line breaks added for readability):

ERROR: /home/tcal/xls-export/xls/build_rules/BUILD:126:12: 
no such target '@rules_hdl//pdk:build_defs.bzl': 
target 'build_defs.bzl' not declared in package 'pdk' defined by
 /usr/local/google/home/tcal/.cache/bazel/_bazel_tcal/69bdc7c11d7de775bee1f8b708726bda/external/rules_hdl/pdk/BUILD;
however, a source file of this name exists.  
(Perhaps add 'exports_files(["build_defs.bzl"])' to pdk/BUILD?) 
and referenced by '//xls/build_rules:xls_codegen_rules_bzl'

@tcal-x tcal-x changed the title Export pdk/build_defs.bzl so that StandardCellInfo can be used. Export pdk/build_defs.bzl so that StandardCellInfo can be used (and tested) by XLS Sep 28, 2023
@QuantamHD
Copy link
Collaborator

Interesting. Didn't know that.

@QuantamHD QuantamHD merged commit b3d3a2a into main Sep 28, 2023
5 checks passed
@mithro mithro deleted the publish-stdcell-info branch October 4, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants