Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the py_XXX targets. #223

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Load the py_XXX targets. #223

merged 1 commit into from
Nov 13, 2023

Conversation

mithro
Copy link
Member

@mithro mithro commented Nov 12, 2023

Use the targets from @rules_python//python:defs.bzl rather than the native targets (which are being deprecated).

@mithro mithro requested a review from QuantamHD November 12, 2023 20:39
@mithro
Copy link
Member Author

mithro commented Nov 12, 2023

grep -R 'py_' $(find -name BUILD\*) | sort | uniq shows that all BUILD files that use py_XXX targets are loading the @rules_python//python:defs.bzl rules.

@mithro
Load the py_XXX targets.
6a6daa9 
Use the targets from `@rules_python//python:defs.bzl` rather than the
native targets (which are being deprecated).

Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@QuantamHD
Copy link
Collaborator

LGTM

@mithro mithro merged commit 43ed222 into hdl:main Nov 13, 2023
4 checks passed
@mithro mithro deleted the py-targets-fix branch November 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantamHD QuantamHD QuantamHD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mithro @QuantamHD