Add *Machine.cc files that are included by Machine.cc. #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenRoad includes different *Machine.cc files on different platforms, and only Linux was previously included. This change makes all files available to be included.
|
/gcbrun |
|
This is going to lead to ODR violations. You'll need to bazel select them based on the @platforms// target. |
|
I don't think it should because it's stuffed into I don't disagree that selecting them would be less confusing, though I'm a little unsure of how to do that in a way that won't be fighting the platform detection they do. |
|
I think technically these should be included in the textual_hdrs, and not the regular hdrs since they aren't meant to be compiled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenRoad includes different
Machine*.ccfiles on different platforms, and only Linux was previously included. This change makes all files available to be included.