Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build packages for python 3.10 #345

Merged
merged 3 commits into from
Jul 20, 2023
Merged

build packages for python 3.10 #345

merged 3 commits into from
Jul 20, 2023

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Jul 20, 2023

  • github/workflow: add py310 entries
  • openroad: use PYTHON_VERSION
  • klayout: use pin_compatible
  • openlane: update test design
  • misc/open_pdks: move python to build dep
  • misc/netgen: remove python dep

Related #343 #72

@proppy
Copy link
Contributor Author

proppy commented Jul 20, 2023

@ajelinski @kgugala @umarcor does that sounds like the right thing to do?

pnr/openroad/meta.yaml Show resolved Hide resolved
.github/workflows/Build.yml Show resolved Hide resolved
@proppy proppy requested a review from ajelinski July 20, 2023 15:47
@proppy
Copy link
Contributor Author

proppy commented Jul 20, 2023

@ajelinski does this look good to you?

@ajelinski
Copy link
Contributor

@ajelinski does this look good to you?

The changes strictly related to the Python 3.10 addition LGTM.

Can't say much about other changes but if the packages are built correctly with such requirement changes, open_pdks.sky130a needs the new patch and openlane should be tested with -design spm instead of -design inverter then also LGTM.

@proppy
Copy link
Contributor Author

proppy commented Jul 20, 2023

@ajelinski do you prefer that I split those in separate PRs?

The issue is that I couldn't really test those, since they were all related (we can't test python 3.10 without design changes for broken packages, and we can't test the design changes without python 3.10 fixes because of dep conflicts)

@ajelinski
Copy link
Contributor

@ajelinski do you prefer that I split those in separate PRs?

The issue is that I couldn't really test those, since they were all related (we can't test python 3.10 without design changes for broken packages, and we can't test the design changes without python 3.10 fixes because of dep conflicts)

Sure, it's not the best approach but I guess it's better than the alternatives.

I didn't suggest separate PRs though. I mostly wanted to say that I don't see any problems with the changes but at the same time I just lack knowledge about these packages to say all of them are correct.

Perhaps you could squash the Openroad and Build.yml changes into the original commit. Otherwise LGTM. @umarcor ?

proppy added 3 commits July 21, 2023 05:47
- add py310 variant in workflow
- openroad: use PYTHON_VERSION
- klayout: use pin_compatible
- github/workflows: restore symbiyosys skipped builds
- pnr/openroad: add py_suffix
- misc/netgen: remove python dep
- misc/open_pdks: move python to build req
@proppy
Copy link
Contributor Author

proppy commented Jul 20, 2023

rebased, and squashed!

Thanks @ajelinski for the quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants