-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build packages for python 3.10 #345
Conversation
@ajelinski @kgugala @umarcor does that sounds like the right thing to do? |
@ajelinski does this look good to you? |
The changes strictly related to the Python 3.10 addition LGTM. Can't say much about other changes but if the packages are built correctly with such requirement changes, |
@ajelinski do you prefer that I split those in separate PRs? The issue is that I couldn't really test those, since they were all related (we can't test python 3.10 without design changes for broken packages, and we can't test the design changes without python 3.10 fixes because of dep conflicts) |
Sure, it's not the best approach but I guess it's better than the alternatives. I didn't suggest separate PRs though. I mostly wanted to say that I don't see any problems with the changes but at the same time I just lack knowledge about these packages to say all of them are correct. Perhaps you could squash the Openroad and |
- add py310 variant in workflow - openroad: use PYTHON_VERSION - klayout: use pin_compatible - github/workflows: restore symbiyosys skipped builds - pnr/openroad: add py_suffix - misc/netgen: remove python dep - misc/open_pdks: move python to build req
rebased, and squashed! Thanks @ajelinski for the quick review. |
Related #343 #72